Reduce integration tests memory usage #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
thomas11
approved these changes
Jan 16, 2025
- Only load json files into memory once for all tests. - Don't run upgrade tests in parallel as they're pretty fast but do start sub-processes. Before: ~5.8gb peek memory and took 181.616s After: ~1.5gb peek memory and took 203.108s
danielrbradley
force-pushed
the
fix-test-memory-usage
branch
from
8069d37 to
8db000f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3864 +/- ##
=======================================
Coverage 57.11% 57.12%
=======================================
Files 79 79
Lines 12407 12407
=======================================
+ Hits 7086 7087 +1
+ Misses 4794 4793 -1
Partials 527 527 ☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v2.83.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: ~5.8gb peek memory and took 181.616s
After: ~2.6gb peek memory and took 203.108s