Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the default version as an explicit version in v3 #3924

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Don't include the default version as an explicit version in v3 #3924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions provider/pkg/versioning/gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ func (v VersionMetadata) ShouldInclude(moduleName openapi.ModuleName, version *o
if version == nil {
return true
}
// Keep any resources in the default version lock
if v.DefaultVersions.IsAtVersion(moduleName, typeName, *version) {
// In v2 only: Keep any default versions as explicit versions too
if v.MajorVersion < 3 && v.DefaultVersions.IsAtVersion(moduleName, typeName, *version) {
return true
}
// Keep any resources in the previous version lock for easier migration
Expand Down
Loading