Restore ability to run acceptance tests in this repo #410
Conversation
t0yv0
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
2 similar comments
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
| @@ -23,7 +23,6 @@ func TestAccRecordTs(t *testing.T) { | |||
| func getJSBaseOptions(t *testing.T) integration.ProgramTestOptions { | |||
| base := getBaseOptions(t) | |||
| baseJS := base.With(integration.ProgramTestOptions{ | |||
| RunUpdateTest: true, | |||
There was a problem hiding this comment.
AccountID property is newly required since the baseline version so this needs to be disabled for now.
t0yv0
requested review from
a team,
iwahbe and
aq17
and removed request for
a team
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
A great fix! Next time, I'd love to see a description according to our standards. We do read your PRs, and having a brief description really helps. Thank you! |
No description provided.