Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E buildx tests #996

Closed
wants to merge 11 commits into from
Closed

E2E buildx tests #996

wants to merge 11 commits into from

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Feb 15, 2024

This adds some E2E buildx examples to showcase the proposed APIs.

An early draft of the documentation is deployed here if it would be easier for you to review in that format.

Examples were written in yaml first and converted to ts / py / java / go / cs.

Open questions:

  • I'm debating changing { cacheTo: [...], cacheFrom: [...] } into { cache: { to: [...], from: [...] } but opted against it since to and from tend to be reserved keywords. I do think it's helpful to encapsulate all of the caching concerns under one object, though. Would { cache: { cacheTo: [...], cacheFrom: [...] } } be reasonable?
  • I'm questioning whether there's any benefit to including manifests as an output. I'm leaning towards removing these, since the digests output is easier to access and gives you the tags you care about.
  • I've made platform into an enum since there are only a few dozen platforms that we support, and it seemed useful from a validation and discoverability standpoint. I could see this being a hindrance, though, so I'm very open to rolling this back if we feel it makes things less usable.

Fixes #971

@blampe
Copy link
Contributor Author

blampe commented Feb 15, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blampe and the rest of your teammates on Graphite Graphite

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • buildx/image.Image

Maintainer note: consult the runbook for dealing with any breaking changes.

@blampe blampe force-pushed the dockerfile-context branch 6 times, most recently from 01dd7fe to fec2b7a Compare February 17, 2024 06:23
@blampe blampe force-pushed the e2e branch 6 times, most recently from 6cf533e to 164f476 Compare February 20, 2024 19:37
@blampe blampe force-pushed the e2e branch 5 times, most recently from 567f931 to edb4a48 Compare February 20, 2024 21:39
@blampe blampe force-pushed the dockerfile-context branch 3 times, most recently from 0241e42 to 3f6b7a9 Compare February 21, 2024 20:18
@blampe blampe force-pushed the e2e branch 2 times, most recently from 9780073 to 4ca908e Compare February 21, 2024 22:04
@blampe blampe force-pushed the dockerfile-context branch from 3f6b7a9 to bad0f91 Compare March 5, 2024 20:54
@blampe blampe force-pushed the e2e branch 4 times, most recently from 597a8c6 to 77f1831 Compare March 6, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant