-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E buildx tests #996
Closed
Closed
E2E buildx tests #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2024
Closed
Closed
Closed
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blampe
force-pushed
the
api-types
branch
2 times, most recently
from
February 16, 2024 20:12
839817c
to
dff1663
Compare
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
blampe
force-pushed
the
dockerfile-context
branch
6 times, most recently
from
February 17, 2024 06:23
01dd7fe
to
fec2b7a
Compare
blampe
force-pushed
the
e2e
branch
6 times, most recently
from
February 20, 2024 19:37
6cf533e
to
164f476
Compare
blampe
force-pushed
the
e2e
branch
5 times, most recently
from
February 20, 2024 21:39
567f931
to
edb4a48
Compare
blampe
force-pushed
the
dockerfile-context
branch
3 times, most recently
from
February 21, 2024 20:18
0241e42
to
3f6b7a9
Compare
blampe
force-pushed
the
e2e
branch
2 times, most recently
from
February 21, 2024 22:04
9780073
to
4ca908e
Compare
blampe
force-pushed
the
dockerfile-context
branch
from
March 5, 2024 20:54
3f6b7a9
to
bad0f91
Compare
blampe
force-pushed
the
e2e
branch
4 times, most recently
from
March 6, 2024 00:14
597a8c6
to
77f1831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some E2E buildx examples to showcase the proposed APIs.
An early draft of the documentation is deployed here if it would be easier for you to review in that format.
Examples were written in yaml first and converted to ts / py / java / go / cs.
Open questions:
{ cacheTo: [...], cacheFrom: [...] }
into{ cache: { to: [...], from: [...] }
but opted against it sinceto
andfrom
tend to be reserved keywords. I do think it's helpful to encapsulate all of the caching concerns under one object, though. Would{ cache: { cacheTo: [...], cacheFrom: [...] } }
be reasonable?digests
output is easier to access and gives you the tags you care about.Fixes #971