Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "unable to detect a global setting for GCP Project" warning. #1168

Closed
shadiramadan opened this issue Aug 26, 2023 · 5 comments · Fixed by #2701
Closed

Remove "unable to detect a global setting for GCP Project" warning. #1168

shadiramadan opened this issue Aug 26, 2023 · 5 comments · Fixed by #2701
Assignees
@rshade
Labels
area/providers awaiting/bridge The issue cannot be resolved without action in pulumi-terraform-bridge. impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@shadiramadan
Copy link

pulumi-gcp/provider/resources.go

Line 318 in f0115d9

msg := "unable to detect a global setting for GCP Project;\n" +

I have pulumi configuration which creates GCP projects (thus no global project ID is set) and I've found this warning very annoying in my outputs.

Could we remove or supress this specific warning?
@mikhailshilkov mikhailshilkov added the needs-triage Needs attention from the triage team label Aug 28, 2023
@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec kind/enhancement Improvements or new features impact/reliability Something that feels unreliable or flaky area/providers and removed kind/bug Some behavior is incorrect or out of spec labels Aug 28, 2023
@iwahbe
Copy link
Member

iwahbe commented Aug 28, 2023 •
edited
Loading

Hi @shadiramadan. Thanks for telling us about the issue. I agree that the warning should be addressable. Looks like the warning was put in to address #890.

@guineveresaenger
Copy link
Contributor

Per discussion with @iwahbe:

We believe we can implement this in the following way:

  1. When the warning first appears, we can allow/instruct the user to explicitly bypass it via explicitly setting gcp:project to something like "No Project" or any other string that is invalid to use for GCP Projects and thus not a potential Project name.
  2. We then look for this value in our pre-config check and set Project to a pulumi-internal constant.
  3. When this constant is detected on a stack, we know the user does not need the warning, and skip it.
  4. We will adjust the warning text to include override instructions.

@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Aug 28, 2023
@SpainTrain
Copy link

Curious whether there is any progress on this?

Configurable warnings (generally, and specific to this) are very helpful for better DX. In our case developers think they are doing something wrong when they interact with our stacks because we do not use the default project feature. Thanks!

@rshade rshade self-assigned this Nov 18, 2024
rshade added a commit that referenced this issue Nov 18, 2024
@rshade
Adding in support for a "No Project" setting for gcp:project, fixes #…
4e1d52b 
…1168
@guineveresaenger guineveresaenger mentioned this issue Nov 18, 2024
Closed
rshade added a commit that referenced this issue Nov 19, 2024
@rshade
Adding in support for a "No Project" setting for gcp:project, fixes #…
b69bbde 
…1168
rshade added a commit that referenced this issue Nov 19, 2024
@rshade
Adding in support for a "No Project" setting for gcp:project, fixes #…
30c4eb7 
…1168
rshade added a commit that referenced this issue Nov 19, 2024
@rshade
Adding in support for a "No Project" setting for gcp:project, fixes #…
0416cd6 
…1168
rshade added a commit that referenced this issue Nov 19, 2024
@rshade
Adding in support for a "No Project" setting for gcp:project, fixes #…
642c6b8 
…1168
rshade added a commit that referenced this issue Nov 20, 2024
@rshade
Adding in support for a "No Project" setting for gcp:project, fixes #…
5f715d4 
…1168
rshade added a commit that referenced this issue Dec 2, 2024
@rshade
Adding in disableGlobalProjectWarning, fixes #1168
1ee0a59
rshade added a commit that referenced this issue Dec 3, 2024
@rshade
Adding in disableGlobalProjectWarning, fixes #1168
d079150
rshade added a commit that referenced this issue Dec 3, 2024
@rshade
Adding in disableGlobalProjectWarning, fixes #1168
9b65c68
rshade added a commit that referenced this issue Dec 3, 2024
@rshade
Adding in disableGlobalProjectWarning, fixes #1168
5569507
@rshade rshade mentioned this issue Dec 4, 2024
Merged
@VenelinMartinov VenelinMartinov mentioned this issue Dec 9, 2024
Closed
@VenelinMartinov VenelinMartinov added the awaiting/bridge The issue cannot be resolved without action in pulumi-terraform-bridge. label Dec 10, 2024
@VenelinMartinov
Copy link
Contributor

blocked on pulumi/pulumi-terraform-bridge#2702

rshade added a commit that referenced this issue Dec 10, 2024
@rshade
Adding in disableGlobalProjectWarning, fixes #1168
64e6ccf
rshade added a commit that referenced this issue Dec 10, 2024
@rshade
Adding in disableGlobalProjectWarning, fixes #1168
35682b7
rshade added a commit that referenced this issue Dec 11, 2024
@rshade
Adding in disableGlobalProjectWarning, fixes #1168 (#2701)
c3b597e 
Adds `disableGlobalProjectWarning` to the ExtraConfig for the provider,
allowing users to disable the initial default project. This fixes #1168
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 11, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2701 and shipped in release v8.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshade rshade

Labels
area/providers awaiting/bridge The issue cannot be resolved without action in pulumi-terraform-bridge. impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
8 participants
@rshade @SpainTrain @shadiramadan @mikhailshilkov @guineveresaenger @iwahbe @VenelinMartinov @pulumi-bot