Helm - v3 Release leaks resources on ctrl-c command #2485
Assignees
Labels
area/helm
customer/feedback
Feedback from customers
customer/lighthouse
Lighthouse customer bugs and enhancements
impact/quality
kind/bug
Some behavior is incorrect or out of spec
resolution/fixed
This issue was fixed
Milestone
Comments
phillipedwards
added
kind/bug
|
@phillipedwards just want to clarify – when you say "leak" the resources, do you mean they are created by Pulumi but not recorded in state since the operation is killed? |
aq17
added
awaiting-feedback
|
@aq17 exactly! |
aq17
added
area/helm
impact/quality
and removed
awaiting-feedback
mnlumi
added
customer/feedback
|
When the deployment is cancelled, the Helm provider should use the There's a blocking issue (the |
EronWright
added a commit
that referenced
this issue
Sep 29, 2023
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
Closes #2485.
This PR implements cancelation for `Create` and `Update` operations on
the Helm Release resource. When the user presses ctrl-c, the Helm
operation is cancelled and the stack state is updated accordingly. This
is an improvement over the current behavior where the Helm release may
be orphaned by Pulumi.
A future enhancement would be to implement cancelation for the `Delete`
operation, once it becomes possible in the Helm v3 library (see
[PR](helm/helm#12109) and the `RunWithContext`
variants).
_Note: no new tests are provided because I don't see a way to simulate
cancelation using the integration test framework._
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Related to pulumi/pulumi#14057. It is safe to
merge this PR beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
During a deployment of helm v3 release, if the user hits ctrl-c Pulumi will leak the resources that have already been created, causing the user to have to manually find and remove the kubernetes resources deployed by the Helm release.
Expected Behavior
Any resources created should not be leaked during a ctrl-c.
Steps to reproduce
deploy a helm release and ctrl-c during an in-flight update.
Output of
pulumi aboutpulumi/pulumi v3.73.0
pulumi/kubernetes v3.30.0
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: