-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulumi import by passing json file is failing #2596
Comments
@EronWright This sounds like a regression from #2568, could you take a look? |
I am able to reproduce this issue, and I agree that it is a regression from #2568. Some repro notes (WIP):
|
This comment was marked as resolved.
This comment was marked as resolved.
To provide a brief update, a potential fix has been implemented and is being tested: |
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes This is a series of commits to fix a p1 and to improve the import of Helm Releases. The regression occurred because `Read` attempted to use the provider-generated inputs to compute a checksum, and returned an error if it couldn't, and this caused the `pulumi import` tool to fail in cases where the inputs aren't guessable. The fix is to eat the problem during `Read`. While implementing the fix, it became apparent that the templating code for the `Release` resource should be decoupled from the `Chart` resource, mainly to improve the consistency of how chart names are handled. Specific changes: - suppress error in computing inputs during `Read`. - decouple the templating code. - simplify the chart linting code. - use a timeout that is consistent with the Delete op. - new tests for the import variants. <!--Give us a brief description of what you've done and what it solves. --> Closes #2596 ### Related issues (optional) <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. --> --------- Co-authored-by: Ramon Quitales <[email protected]>
@yogeshghotekar we published a fix in |
This is still actual in v4.5.4. We should reopen |
@rhuanbarreto could you elaborate on the specific issue that you are seeing? Some output would really help, thanks. |
What happened?
I am trying to import resource define in json file to pulumi but is failing to import the helm charts
This started failing on pulumi-kubernetes provider v4.3.0 It works fine with v4.2.0
Example
To reproduce this issue. You can create resources in json file. In my case I am creating this resource json file from my terraform deployed resources and then trying to import it in pulumi.
json file
my resource creation code
once json file is ready execute below command
pulumi import -f ./vars/bulk-import.json --protect=false --generate-code=false
Error:
This works fine with pulumi-kuberenetes provider v4.2.0 and failing on v4.3.0
Output of
pulumi about
CLI
Version 3.85.0
Go Version go1.21.1
Go Compiler gc
Plugins
NAME VERSION
go unknown
Host
OS debian
Version 12.1
Arch x86_64
This project is written in go: executable='/usr/local/go/bin/go' version='go version go1.20.8 linux/amd64'
Additional context
Suspecting the issue is due to changes #2568 added in v4.3.0 I tried ignoreChanges: ["checksum"] but still it is failing for pulumi import
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: