-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor v2/yaml parsing code #2888
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2888 +/- ##
==========================================
+ Coverage 26.91% 26.97% +0.06%
==========================================
Files 53 53
Lines 7736 7748 +12
==========================================
+ Hits 2082 2090 +8
- Misses 5481 5483 +2
- Partials 173 175 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactor looks good. Thanks for extending the tests!
fd9fc85
to
f2d51a3
Compare
Proposed changes
This PR doesn't make any substantive changes to the provider, it breaks apart the parsing-and-registration code into two independent functions, in anticipation of applying component-specific sorting strategies.
Specifics:
Parse
andRegister
Related issues (optional)