Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor v2/yaml parsing code #2888

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Refactor v2/yaml parsing code #2888

merged 5 commits into from
Mar 19, 2024

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Mar 15, 2024

Proposed changes

This PR doesn't make any substantive changes to the provider, it breaks apart the parsing-and-registration code into two independent functions, in anticipation of applying component-specific sorting strategies.

Specifics:

  • split the logic into Parse and Register
  • split the test code accordingly
  • enriches the registration data that is collected by the mock resource monitor

Related issues (optional)

@EronWright EronWright added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Mar 15, 2024
@EronWright EronWright requested a review from rquitales March 15, 2024 17:46
@EronWright EronWright self-assigned this Mar 15, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 26.97%. Comparing base (1d7e3b6) to head (de3f420).

Files Patch % Lines
provider/pkg/provider/yaml/v2/yaml.go 78.94% 4 Missing ⚠️
provider/pkg/provider/yaml/v2/configfile.go 83.33% 1 Missing and 1 partial ⚠️
provider/pkg/provider/yaml/v2/configgroup.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2888      +/-   ##
==========================================
+ Coverage   26.91%   26.97%   +0.06%     
==========================================
  Files          53       53              
  Lines        7736     7748      +12     
==========================================
+ Hits         2082     2090       +8     
- Misses       5481     5483       +2     
- Partials      173      175       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks good. Thanks for extending the tests!

@EronWright EronWright force-pushed the eronwright/yaml-refactor branch from fd9fc85 to f2d51a3 Compare March 19, 2024 21:05
@EronWright EronWright enabled auto-merge (squash) March 19, 2024 21:06
@EronWright EronWright merged commit 0afc560 into master Mar 19, 2024
17 of 18 checks passed
@EronWright EronWright deleted the eronwright/yaml-refactor branch March 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants