Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SDKv2 pulcheck test library to internal/ #2712

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 10, 2024

This is a pure refactor. The pulcheck module was previously public in order to allow it to be used with the PF bridge. Now that pf is under pkg we can make this module internal again.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Dec 10, 2024

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.52%. Comparing base (22ff1c4) to head (f44bf76).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2712      +/-   ##
==========================================
- Coverage   69.53%   69.52%   -0.01%     
==========================================
  Files         301      301              
  Lines       38646    38646              
==========================================
- Hits        26871    26869       -2     
- Misses      10254    10257       +3     
+ Partials     1521     1520       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is triggering a linter failure.

LGTM

@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_verbose_flag_from_tests branch from a6b246c to b3398f6 Compare December 10, 2024 17:31
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_pulcheck_to_internal branch from a8594a2 to 545a6f3 Compare December 10, 2024 17:31
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_pulcheck_to_internal branch from 545a6f3 to f44bf76 Compare December 10, 2024 17:33
Base automatically changed from vvm/remove_verbose_flag_from_tests to master December 10, 2024 18:25
@VenelinMartinov VenelinMartinov merged commit 143b3ee into master Dec 10, 2024
30 of 31 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/move_sdkv2_pulcheck_to_internal branch December 10, 2024 18:33
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.98.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants