-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SDKv2 pulcheck test library to internal/ #2712
Conversation
This change is part of the following stack: Change managed by git-spice. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2712 +/- ##
==========================================
- Coverage 69.53% 69.52% -0.01%
==========================================
Files 301 301
Lines 38646 38646
==========================================
- Hits 26871 26869 -2
- Misses 10254 10257 +3
+ Partials 1521 1520 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is triggering a linter failure.
LGTM
a6b246c
to
b3398f6
Compare
a8594a2
to
545a6f3
Compare
545a6f3
to
f44bf76
Compare
This PR has been shipped in release v3.98.0. |
This is a pure refactor. The
pulcheck
module was previously public in order to allow it to be used with the PF bridge. Now thatpf
is underpkg
we can make this module internal again.