Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full fidelity SDKv2 crosstest.Configure equality #2842

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 17, 2025

Stacked on top of #2840.

This switches crosstest.Configure over to using a stronger comparison function.

Fixes #2521

@iwahbe iwahbe self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (7cc82df) to head (4720fb5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2842   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files         325      325           
  Lines       41633    41633           
=======================================
  Hits        28094    28094           
  Misses      11959    11959           
  Partials     1580     1580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe marked this pull request as ready for review January 17, 2025 15:26
@iwahbe iwahbe requested review from VenelinMartinov and a team January 17, 2025 15:27
Base automatically changed from iwahbe/full-fidelity-create-cross-tests to master January 17, 2025 15:27
Stacked on top of #2840.

This switches `crosstest.Configure` over to using a stronger comparison function.

Fixes #2521
@iwahbe iwahbe force-pushed the iwahbe/full-fidelity-configure-cross-tests branch from a05726b to 4720fb5 Compare January 17, 2025 15:28
@iwahbe iwahbe merged commit 80add2e into master Jan 17, 2025
69 checks passed
@iwahbe iwahbe deleted the iwahbe/full-fidelity-configure-cross-tests branch January 17, 2025 15:50
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.102.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert full equality on *schema.ResourceData in SDKv2 cross-tests
3 participants