Skip to content
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.

chore(deps): bump actions/setup-node from 3.4.1 to 3.5.0 #19

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 27, 2022

Bumps actions/setup-node from 3.4.1 to 3.5.0.

Release notes

Sourced from actions/setup-node's releases.

Add support for engines.node and Volta

In scope of this release we add support for engines.node. The action will be able to grab the version form package.json#engines.node. actions/setup-node#485. Moreover, we added support for Volta

Besides, we updated @​actions/core to 1.9.1 and @​actions/cache to 3.0.4

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.4.1 to 3.5.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@2fddd88...969bd26)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from dirien as a code owner September 27, 2022 15:24
@@ -63,7 +63,7 @@ jobs:
- name: Install Pulumi CLI
uses: pulumi/action-install-pulumi-cli@b374ceb6168550de27c6eba92e01c1a774040e11 # tag=v2.0.0
- name: Setup Node
uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 # tag=v3.4.1
uses: actions/setup-node@969bd2663942d722d85b6a8626225850c2f7be4b # tag=v3.4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirien I would have expected that Dependabot would update the tag name in the comment to remain in sync. Wrong expectations on my side?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mixed it up with the renovate bot!

There is a Issue dependabot/dependabot-core#4691 regarding this, and I plan on creating a PR for this. I think this is very important.

So for now pining to commit hash is for me mandatory best practice in terms of supply chain security but currently hard to challenging to read.

Again, my PR will bring the renovate feature to dependabot too!

Copy link
Collaborator

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dependabot squash and merge#

@dependabot dependabot bot merged commit 7b1935a into main Sep 28, 2022
@dependabot dependabot bot deleted the dependabot/github_actions/actions/setup-node-3.5.0 branch September 28, 2022 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants