Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: enable GNU/Linux support 🐧 #12

Merged
merged 1 commit into from
Feb 4, 2021
Merged

bugfix: enable GNU/Linux support 🐧 #12

merged 1 commit into from
Feb 4, 2021

Conversation

alexanderadam
Copy link
Contributor

Hi folks,

this PR finally adds GNU/Linux support to the homebrew package.
Thus it should fix #4.

Thank you for your work! 🙏

@alexanderadam alexanderadam mentioned this pull request Feb 2, 2021
Merged
@nonrational nonrational self-requested a review February 3, 2021 02:24
nonrational
nonrational requested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@nonrational nonrational left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way cool! Also, I'm pretty sure this counts as an enhancement 😀

puma-dev.rb Show resolved Hide resolved
puma-dev.rb Show resolved Hide resolved
@alexanderadam
Copy link
Contributor Author

alexanderadam commented Feb 3, 2021 •
edited
Loading

Way cool! Also, I'm pretty sure this counts as an enhancement grinning

Thank you. Although I should have opened this PR instead of the issue in 2017. 😉
But I guess better late than never. 😆

puma-dev -setup is only available in the macOS build. 😞 I think we just want to refer people directly to https://github.com/puma/puma-dev#linux-support, as you've done below.

Please write me in case you plan to add puma-dev -setup support for GNU/Linux, too and I can help (without having to write Go).

@alexanderadam alexanderadam removed their assignment Feb 3, 2021
@nonrational nonrational merged commit f4f70d3 into puma:master Feb 4, 2021
@alexanderadam alexanderadam deleted the bugfix/linux-support-4 branch February 4, 2021 14:32
@nonrational nonrational mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonrational nonrational nonrational approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux support
2 participants
@alexanderadam @nonrational