Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for .pumaenv file #251

Merged
merged 2 commits into from
Jun 4, 2020
Merged

add support for .pumaenv file #251

merged 2 commits into from
Jun 4, 2020

Conversation

koenpunt
Copy link
Contributor

@koenpunt koenpunt commented Jun 4, 2020

Since using .powenv feels wrong, since this is not pow, and .env conflicts with Docker's default .env loading (Docker only supports plain variable assignments), I figured it might be good to have a Puma-named env file.

koenpunt added 2 commits June 4, 2020 15:04
Since using `.powenv` feels wrong, since this is not pow, and `.env` conflicts with Docker's default `.env` loading (Docker only supports plain variable assignments), I figured it might be good to have a Puma-named env file.
Copy link
Member

@nonrational nonrational left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@nonrational nonrational merged commit 5af3181 into puma:master Jun 4, 2020
@koenpunt koenpunt deleted the patch-1 branch June 4, 2020 13:18
nonrational added a commit that referenced this pull request Aug 12, 2020
* origin/master:
  Update Webpack Dev Server guide to be nicer to Sprockets (#254)
  add support for .pumaenv file (#251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants