This repository has been archived by the owner on May 27, 2020. It is now read-only.
Allow creation of CSV files with newlines in fields #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…InValues property to json2csv
In some cases, we want albedo to delete all previous files, regardless of age. This allows us to set removeOlderThan to 0.
Fix issue where we were matching file names poorly for deletion.
Modify report generation to use streaming operations
We need to try and clean up before jumping ship on other errors.
Consider empty and wasError together.
reverteroo!
Update albedo.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json2csv recently added an option for
preserveNewLinesInValueswhich allows you to create CSV files containing a newline (\r) within a field. It would be great if albedo supported that.