(chocolateyGH-685) Improve standard remote view

Improve the standard remote view and detailed view. Also add the package icon to the detailed view. (chocolateyGH-685) Improve standard remote view
punker76 · Mar 3, 2021 · 42b4506 · 42b4506
1 parent b1322dc
commit 42b4506
Show file tree

Hide file tree

Showing 5 changed files with 206 additions and 100 deletions.
diff --git a/Source/ChocolateyGui.Common.Windows/ChocolateyGui.Common.Windows.csproj b/Source/ChocolateyGui.Common.Windows/ChocolateyGui.Common.Windows.csproj
@@ -260,7 +260,6 @@
     <Compile Include="Utilities\Converters\NullToValue.cs" />
     <Compile Include="Utilities\Converters\NullToVisibility.cs" />
     <Compile Include="Utilities\Converters\PackageDependenciesToString.cs" />
-    <Compile Include="Utilities\Converters\PackageTitleConverter.cs" />
     <Compile Include="Utilities\Converters\StringListToString.cs" />
     <Compile Include="Utilities\DataContext.cs" />
     <Compile Include="Utilities\DataGridCustomSortBehavior.cs" />

diff --git a/Source/ChocolateyGui.Common.Windows/Utilities/Converters/PackageTitleConverter.cs b/Source/ChocolateyGui.Common.Windows/Utilities/Converters/PackageTitleConverter.cs
diff --git a/Source/ChocolateyGui.Common.Windows/Utilities/Converters/StringListToString.cs b/Source/ChocolateyGui.Common.Windows/Utilities/Converters/StringListToString.cs
@@ -17,8 +17,13 @@ public class StringListToString : IValueConverter
     {
         public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
         {
+            if (value is string valueAsString)
+            {
+                return string.Join(", ", valueAsString.Split(new[] { " ", ",", ";", "|" }, StringSplitOptions.RemoveEmptyEntries).Select(item => item.Trim()));
+            }
+
             return value is IEnumerable<string> items
-                ? string.Join(", ", items.Select(item => item.Trim()).ToList())
+                ? string.Join(", ", items.Select(item => item.Trim()))
                 : string.Empty;
         }
 

diff --git a/Source/ChocolateyGui.Common.Windows/Views/LocalSourceView.xaml b/Source/ChocolateyGui.Common.Windows/Views/LocalSourceView.xaml
@@ -137,7 +137,7 @@
             </Style.Triggers>
         </Style>
 
-        <Style TargetType="{x:Type ListView}" BasedOn="{StaticResource MahApps.Styles.ListView.Virtualized}">
+        <Style TargetType="{x:Type ListView}" BasedOn="{StaticResource MahApps.Styles.ListView}">
             <Style.Resources>
                 <!--  this is necessary to prevent nasty can not find stuff like  -->
                 <!--  ItemsPanel Cannot find source for binding with reference 'RelativeSource FindAncestor, AncestorType='System.Windows.Controls.ItemsControl', AncestorLevel='1''. BindingExpression:Path=HorizontalContentAlignment; DataItem=null; target element is 'ListViewItem' (Name=''); target property is 'HorizontalContentAlignment' (type 'HorizontalAlignment')  -->