refactor: 优化代码

pupilcc · Jun 14, 2022 · 4f910c6 · 4f910c6
1 parent 52ef8db
commit 4f910c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/com/pupilcc/pushbot/extension/ApiResult.java b/src/main/java/com/pupilcc/pushbot/extension/ApiResult.java
@@ -75,15 +75,15 @@ public static <T> ApiResult<T> failed(IErrorCode errorCode) {
         return restResult(null, errorCode);
     }
 
-    public boolean ok() {
-        return ApiErrorCode.SUCCESS.getCode() == this.code;
+    public boolean failed() {
+        return ApiErrorCode.SUCCESS.getCode() != this.code;
     }
 
     /**
      * 服务间调用非业务正常，异常直接释放
      */
     public T serviceData() {
-        if (!this.ok()) {
+        if (!this.failed()) {
             throw new ApiException(this.msg);
         } else {
             return this.data;

diff --git a/src/main/java/com/pupilcc/pushbot/service/MessageService.java b/src/main/java/com/pupilcc/pushbot/service/MessageService.java
@@ -51,7 +51,7 @@ public ApiResult<Object> sendMessage(SendMessageDTO dto, String chatToken) {
 
         // 参数校验
         ApiResult apiResult = checkParameter(dto);
-        if (!apiResult.ok()) {
+        if (apiResult.failed()) {
             return apiResult;
         }
         boolean isSend;