fix(webdriver): make sure user agent can be set twice (#13585)

puppeteer · Feb 5, 2025 · 411ff95 · 411ff95
1 parent b42c046
commit 411ff95
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/puppeteer-core/src/bidi/Page.ts b/packages/puppeteer-core/src/bidi/Page.ts
@@ -171,6 +171,7 @@ export class BidiPage extends Page {
     const changeUserAgent = (userAgent: string) => {
       Object.defineProperty(navigator, 'userAgent', {
         value: userAgent,
+        configurable: true,
       });
     };
 
@@ -190,7 +191,7 @@ export class BidiPage extends Page {
         : undefined,
       // When we disable the UserAgent we want to
       // evaluate the original value in all Browsing Contexts
-      frames.map(frame => {
+      ...frames.map(frame => {
         return frame.evaluate(changeUserAgent, userAgent);
       }),
     ]);

diff --git a/test/src/emulation.spec.ts b/test/src/emulation.spec.ts
@@ -204,6 +204,15 @@ describe('Emulation', () => {
         }),
       ).toContain('iPhone');
     });
+
+    it('should work twice on about:blank', async () => {
+      const {page} = await getTestState();
+
+      await page.goto('about:blank');
+      await page.emulate(KnownDevices['iPhone 13']);
+      await page.emulate(KnownDevices['iPad Pro landscape']);
+    });
+
     it('should support clicking', async () => {
       const {page, server} = await getTestState();