Patch - ensure that facts specified by environment variables take precedence #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was this unpleasant inconsistency:
On an OSX host:
$ facter operatingsystem
Darwin
$ facter_operatingsystem=Not_Darwin facter operatingsystem
Not_Darwin
But on a linux/solaris host:
$ facter operatingsystem
CentOS
$ facter_operatingsystem=Not_CentOS facter operatingsystem
CentOS
As the operatingsystem fact resolution for linux-based kernels has higher
precedence than the environment variable as it has more matching confines than
the value from the environment variable.
This patch adds from_environment to the resolution mechanism, which makes the
resolution have an artificially high weight by claiming the length of its confines
array is 1 billion.
|
Unfortunately, we don't use pull requests for the Puppet Labs projects. The Development Lifecycle wiki page has the preferred method of submitting patches. Thanks for doing the work on this! |
|
Hi Richard - can you please rebase this and we'll get it merged. |
|
This was merged in 9f4c5c6 and released in 1.6.0 |
smortex
pushed a commit
to smortex/facter
that referenced
this pull request
Nov 25, 2022
(maint) Minor module cleanup
jiongle1
referenced
this pull request
in scantist-ossops-m2/facter
Apr 5, 2024
Fact 480/1.7.x/security fixes
joshcooper
pushed a commit
to joshcooper/facter
that referenced
this pull request
Jan 27, 2025
Delete unused code coverage workflow and related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.