(PDK-1210) setting inherited const_defined lookup to false #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a top level module with same name as a type which gets loaded before the type gets defined. This will trigger a false positive on the `last_module.const_defined?` check causing an `uninitialized constant` error. This change will no longer do a recursive check and only care about the local namespace this way avoiding the false positive.
Thomas-Franklin
force-pushed
the
const_defined_bug
branch
from
c92d286 to
8650637
Compare
`const_get` has the same convenient - but dangerous - default. In this case the `false` does not matter, since it is protected by the check and set the line above. Being explicit is still a good practice to avoid breaking this inadvertently later should we ever change the logic here.
scotje
approved these changes
Oct 30, 2018
|
@Thomas-Franklin - has there been any movement on this one recently? |
@davidmalloncares it was approved by @scotje, but not sure if it needs more than one approval. I'll update the branch with master and have it ready anyway. |
bmjen
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a top level module with same name as a type which gets loaded before the type gets defined.
This will trigger a false positive on the
last_module.const_defined?check causing anuninitialized constanterror.This change will no longer do a recursive check and only care about the local namespace this way avoiding the false positive.