(maint) Add retries to curl calls in ssl.sh #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds 5 retries (including connection refused) at 2 second intervals to the curl commands being used to download the CA and handle other cert related negotiation. - We're experiencing issues under LCOW where DNS resolution works in early waiter scripts, but subsequently fails when handling certs. This may be due to an unresolved bug in libnetwork OR it may be due to the fact that the Docker DNS resolver is not designed to handle heavy loads and may intermittently fail requests.
underscorgan
approved these changes
Apr 30, 2019
Iristyle
added a commit
that referenced
this pull request
Apr 9, 2021
(maint) Add retries to curl calls in ssl.sh
Iristyle
added a commit
that referenced
this pull request
Apr 9, 2021
(maint) Update compose file to use 'latest' containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 5 retries (including connection refused) at 2 second intervals
to the curl commands being used to download the CA and handle other
cert related negotiation.
We're experiencing issues under LCOW where DNS resolution works in
early waiter scripts, but subsequently fails when handling certs.
This may be due to an unresolved bug in libnetwork OR it may be due
to the fact that the Docker DNS resolver is not designed to handle
heavy loads and may intermittently fail requests.