Add PUPPETSERVER_PORT environment value #85
Conversation
This allows overriding the host port for puppetserver. Improve documentation of environment variables.
There was a problem hiding this comment.
Hi @jchonig , thank you for your contribution! I have a few comments but in general this looks good!
|
|
||
| ### PUPPETWARE_ANALYTICS_ENABLED | ||
|
|
||
| See *Analytics Data Collection* below |
There was a problem hiding this comment.
The analytics data collection section is above this
| ``` | ||
| VOLUME_ROOT=/container_data/pupperware | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I think moving this addition up to before the list of subdirectories would make more sense.
| @@ -68,6 +68,13 @@ PuppetDB | |||
| `Preferences>File Sharing` in order for these directories to be created | |||
| and volume-mounted automatically. There is no need to add each sub directory. | |||
|
|
|||
| The default can be overridden with the `VOLUME_ROOT` environement | |||
| variable in the `.env` file (see *Environment* below) | |||
There was a problem hiding this comment.
| variable in the `.env` file (see *Environment* below) | |
| variable (see *Environment* below) |
Since env variables can be set in the .env file or on the command line I think we can probably just refer to it as environment variable without extra information on where to set it
| ## Environment | ||
|
|
||
| Environment variables may be specified in `.env` file in this | ||
| directory. |
There was a problem hiding this comment.
| directory. | |
| directory or passed in on the command-line when running `docker-compose up`, i.e. `DNS_ALT_NAMES=test.server docker-compose up`. |
|
|
||
| See *Analytics Data Collection* below | ||
|
|
||
| ### PUPPETSERVER_PORT |
There was a problem hiding this comment.
I don't have a great idea for a way to make this variable name more clear, but with the name PUPPETSERVER_PORT my initial thought was that this was going to change the port the container was listening to, not the mapped port on the host running the container. Would like to find a name that makes it a little more clear that this is the mapped port.
|
|
This allows overriding the host port for puppetserver.
Improve documentation of environment variables.
#84