Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Ignore os.release.major related fact diffs on Window 11 #2263

Merged
merged 2 commits into from
Jun 28, 2022
Merged

(maint) Ignore os.release.major related fact diffs on Window 11 #2263

merged 2 commits into from
Jun 28, 2022

Conversation

joshcooper
Copy link
Contributor

@joshcooper joshcooper commented Jun 27, 2022 •
edited
Loading

voxpupuli/beaker#1744, voxpupuli/beaker#1745 must be merged first in order to test Windows 11.

Ignore the fact diff between facter 3 and 4 for os.release.full and related facts

@joshcooper
Copy link
Contributor Author

Passed using d3a3c70edc4316d30c1ddebde37359baa95e2bfc

              - Test Case Summary for suite 'tests' -
       Total Suite Time: 493.26 seconds
      Average Test Time: 15.91 seconds
              Attempted: 31
                 Passed: 25
                 Failed: 0
                Errored: 0
                Skipped: 6
                Pending: 0
                  Total: 31

@joshcooper joshcooper marked this pull request as ready for review June 27, 2022 23:06
@joshcooper joshcooper requested a review from a team as a code owner June 27, 2022 23:06
@tvpartytonight tvpartytonight merged commit 03caefd into puppetlabs:6.x Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvpartytonight tvpartytonight tvpartytonight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcooper @tvpartytonight