Adds puppet-debugger gem to list of dependencies #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heya @logicminds , I just double checked the gem, and it doesn't appear to test on Ruby 2.1 although the gemsepc is open. Would this addition make more sense only for Ruby 2.4+? |
|
I can add 2.1 back to the matrix. And update the gemspec as well.
…On Thu, Sep 19, 2019, 8:29 PM Glenn Sarti ***@***.***> wrote:
Heya @logicminds <https://github.com/logicminds> , I just double checked
the gem, and it doesn't appear to test on Ruby 2.1 although the gemsepc is
open.
Would this addition make more sense only for Ruby 2.4+?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#117?email_source=notifications&email_token=AAEJVPCZWLKBRFDTEOO7CVDQKQ7THA5CNFSM4IYEW2CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7FOGKA#issuecomment-533390120>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEJVPCWBLSC4SSDUPYZD53QKQ7THANCNFSM4IYEW2CA>
.
|
|
https://gitlab.com/puppet-debugger/puppet-debugger/-/jobs/300366206 Added 2.1 back to the matrix. Only testing ruby 2.1 with puppet 4.10 since puppet 5 and 6 use 2.4. Will release puppet-debugger 0.14 with updated gemspec to force ruby >=2.1 |
logicminds
force-pushed
the
debugger
branch
from
e219d19 to
04225b0
Compare
glennsarti
approved these changes
Sep 23, 2019
|
Thanks @logicminds !! |
rodjek
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for the upcoming
pdk consolecommand.