Skip to content

Commit

Permalink
Pinned Rubocop to 0.57.2
Browse files Browse the repository at this point in the history
Rubocop 0.58 has dropped support for ruby 2.1 and now throws.
Conditionally pin rubocop version
  • Loading branch information
da-ar committed Jul 9, 2018
1 parent 481d22c commit 67ded95
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@ group :tests do
gem 'rake', '~> 10.0'
gem 'rspec', '~> 3.0'
gem 'rubocop-rspec'
gem 'rubocop'
# rubocop 0.58 throws when testing against ruby 2.1, so pin to the latest,
# unless we're dealing with jruby...
if RUBY_PLATFORM == 'java'
gem 'rubocop'
else
gem 'rubocop', '0.57.2'
end
gem 'simplecov-console'
# the test gems required for module testing
gem 'puppetlabs_spec_helper', '~> 2.7'
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This is an implementation of the [Resource API](https://github.com/puppetlabs/pu

2. Create a [new module](https://puppet.com/docs/pdk/latest/pdk_generating_modules.html) with the PDK, or work with an existing PDK-enabled module. To create a new module, run `pdk new module <MODULE_NAME>` from the command line, specifying the name of the module. Respond to the dialog questions.

3. To add the the `puppet-resource_api` gem and enable "modern" rspec-style mocking, open the `sync.yml` file in your editor, and add the following content:
3. To add the `puppet-resource_api` gem and enable "modern" rspec-style mocking, open the `sync.yml` file in your editor, and add the following content:

```
# .sync.yml
Expand Down

0 comments on commit 67ded95

Please sign in to comment.