Fix params and properties #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
fix-params-and-properties
branch
from
329e81b to
8951a75
Compare
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 98.47% 98.51% +0.03%
==========================================
Files 9 9
Lines 328 336 +8
==========================================
+ Hits 323 331 +8
Misses 5 5
Continue to review full report at Codecov.
|
Forwarding comment edit notifications into our internal chat means that we need to disable codecov comments down to reduce notification spam. We've tried using `after_n_builds`, but amending the PR meant that codecov then notified for each finishing cell.
Properties and Params need to handle newvalue* differently. Properties need `newvalue` called with an (empty) block. Params are satisfied with the `newvalues` call without a block.
DavidS
force-pushed
the
fix-params-and-properties
branch
from
8951a75 to
cbac405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.