Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec fixes #12

Merged
merged 2 commits into from
Jan 24, 2018
Merged

gemspec fixes #12

merged 2 commits into from
Jan 24, 2018

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Jan 24, 2018

No description provided.

* Drop puppet from gemspec: the regular execution environment (puppet agent) has puppet installed, but not as gem. Requiring it here causes failures through pulling in a second puppet install. In development settings, puppet still gets pulled in through the Gemfile, or the pdk.
* Move hocon from the Gemfile to the gemspec. Since we're using hocon, we should require it at the appropriate place.
@DavidS DavidS added the bug label Jan 24, 2018
@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files           9        9           
  Lines         336      336           
=======================================
  Hits          331      331           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7361208...977553a. Read the comment docs.

@DavidS DavidS merged commit 1fdc4dd into puppetlabs:master Jan 24, 2018
@DavidS DavidS deleted the fixes branch January 24, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant