(PDK-569) puppet resource now displays type name correctly
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
reviewed
Feb 1, 2018
lib/puppet/resource_api/glue.rb
Outdated
| # internalize and protect - needs to go deeper | ||
| @values = resource_hash.dup | ||
| # "name" is a privileged key | ||
| @values[:name] = title | ||
| @values[:type] = type |
There was a problem hiding this comment.
@values is used for property/parameter storage. Use a separate instance var to avoid confusing other parts of the machinery.
There are also no acceptance tests for this, I believe, so it'll require some manual testing.
There was a problem hiding this comment.
This code is particularly hard to unit test, since it would require all of puppet around it to exercise. With proper acceptance testing (even manual), we can give this one a pass on coverage.
|
As discussed in the comments above, this gets a pass on coverage, because the Shim classes are glue code that is only exercised when running the full puppet stack. @tphoney did manual testing to confirm no regressions for this. |
DavidS
changed the title
puppet resource now displays type name correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.