(PDK-536) Proper datatype parsing and checking #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
pdk-536-puppet4-datatypes
branch
2 times, most recently
from
2a0e03f to
956fab5
Compare
DavidS
force-pushed
the
pdk-536-puppet4-datatypes
branch
from
956fab5 to
0764325
Compare
thallgren
suggested changes
Feb 21, 2018
lib/puppet/resource_api.rb
Outdated
| return true if type.instance?(value) | ||
|
|
||
| inferred_type = Puppet::Pops::Types::TypeCalculator.infer_set(value) | ||
| if inferred_type.is_a? Puppet::Pops::Types::PStringType |
There was a problem hiding this comment.
TypeCalculator#infer_set can be rather expensive and the inferred_type is not really of any use unless there's a mismatch so I'd suggest using:
if value.is_a?(String)
instead and move the call to #infer_set down to where the mismatch error is generated.
There was a problem hiding this comment.
Thanks, that makes sense.
DavidS
force-pushed
the
pdk-536-puppet4-datatypes
branch
from
0764325 to
aa5c466
Compare
This uses Puppet4+ pops to parse and check datatypes. This allows types to use the full range of expressibility when declaring attributes.
DavidS
force-pushed
the
pdk-536-puppet4-datatypes
branch
from
aa5c466 to
2ac94e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Puppet4+ pops to parse and check datatypes. This allows types
to use the full range of expressibility when declaring attributes.