Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-889) Read-only support for multiple namevars #76

Merged
merged 1 commit into from
May 9, 2018
Merged

(PDK-889) Read-only support for multiple namevars #76

merged 1 commit into from
May 9, 2018

Conversation

da-ar
Copy link

@da-ar da-ar commented May 9, 2018

No description provided.

@da-ar da-ar requested a review from DavidS May 9, 2018 14:14
DavidS
DavidS reviewed May 9, 2018
View reviewed changes
Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the off-line discussion, rename this to "R/O support" and continue development in the next PR.

spec/acceptance/namevar_spec.rb Outdated
require 'spec_helper'

require 'open3'
require 'tempfile'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used in the tests

spec/fixtures/test_module/lib/puppet/provider/multiple_namevar/multiple_namevar.rb Outdated
end

def update(context, name, should)
require 'pry'; binding.pry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoopsie

@da-ar da-ar changed the title (PDK-889) Support for multiple namevars (PDK-889) Read-only support for multiple namevars May 9, 2018
@DavidS DavidS merged commit 2d5d677 into puppetlabs:master May 9, 2018
@da-ar da-ar deleted the multiple_namevars branch May 21, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS DavidS DavidS left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@da-ar @DavidS