Allow SimpleDevice to be initialized with a config hash
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `SimpleDevice` was only looking for a credentials file to load. This allows for tasks to re-use the same code as providers to connect to devices.
DavidS
added a commit
to DavidS/cisco_ios
that referenced
this pull request
Oct 24, 2018
The Resource API allows a `Hash` with the credentials/config instead of a `file://` URL [since 1.4.0](puppetlabs/puppet-resource_api#96). This commit switches over to using the Resource API Device baseclass to handle this behaviour for us. It also avoids the undeclared dependency on the hocon gem.
shermdog
added a commit
to shermdog/meraki-puppet-module
that referenced
this pull request
Nov 20, 2018
The Resource API allows a `Hash` with the credentials/config instead of a `file://` URL [since 1.4.0](puppetlabs/puppet-resource_api#96). This commit switches over to using the Resource API Device baseclass to handle this behaviour for us. It also avoids the undeclared dependency on the hocon gem.
shermdog
added a commit
to shermdog/meraki-puppet-module
that referenced
this pull request
Nov 21, 2018
The Resource API allows a `Hash` with the credentials/config instead of a `file://` URL [since 1.4.0](puppetlabs/puppet-resource_api#96). This commit switches over to using the Resource API Device baseclass to handle this behaviour for us. It also avoids the undeclared dependency on the hocon gem.
shermdog
added a commit
to shermdog/meraki-puppet-module
that referenced
this pull request
Nov 21, 2018
The Resource API allows a `Hash` with the credentials/config instead of a `file://` URL [since 1.4.0](puppetlabs/puppet-resource_api#96). This commit switches over to using the Resource API Device baseclass to handle this behaviour for us. It also avoids the undeclared dependency on the hocon gem.
shermdog
added a commit
to shermdog/meraki-puppet-module
that referenced
this pull request
Nov 21, 2018
The Resource API allows a `Hash` with the credentials/config instead of a `file://` URL [since 1.4.0](puppetlabs/puppet-resource_api#96). This commit switches over to using the Resource API Device baseclass to handle this behaviour for us. It also avoids the undeclared dependency on the hocon gem.
shermdog
added a commit
to shermdog/meraki-puppet-module
that referenced
this pull request
Nov 21, 2018
The Resource API allows a `Hash` with the credentials/config instead of a `file://` URL [since 1.4.0](puppetlabs/puppet-resource_api#96). This commit switches over to using the Resource API Device baseclass to handle this behaviour for us. It also avoids the undeclared dependency on the hocon gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
SimpleDevicewas only looking for a credentials file to load.This allows for tasks to re-use the same code as providers to connect to
devices.