Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-puppet-gem-provider-for-puppet-agent #3728

Closed

Conversation

kylog
Copy link

@kylog kylog commented Mar 18, 2015

No description provided.

@kylog
Copy link
Author

kylog commented Mar 18, 2015

Note that the second commit here assumes the uninstall_options feature added in #3708, so it will fail spec tests until that is merged.

@puppetcla
Copy link

CLA signed by all contributors.

@melissa melissa added the PL label Mar 18, 2015

has_feature :versionable, :install_options, :uninstall_options

commands :gemcmd => "/opt/puppetlabs/puppet/bin/gem"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support windows too?

@branan
Copy link
Contributor

branan commented Mar 20, 2015

@kylog I didn't expect us to be getting #3708 in until after 4.0 final, which would also block this to 4.1... Is that intended? Do yoy plan to bring the other pull into 4.0?

@kylog
Copy link
Author

kylog commented Mar 20, 2015

@branan ah, good question. Yes, I think this will ease 4.0 adoption so, yes, I'd vote that we should pull this (and #3708) into 4.0.

@branan
Copy link
Contributor

branan commented Mar 24, 2015

@kylog got it. We'll move ahead with merging #3708 this week so we can get this in.

@MikaelSmith
Copy link
Contributor

#3708 has been merged.

@branan
Copy link
Contributor

branan commented Mar 31, 2015

@kylog can you refresh this commit somehow so we can get travis to re-run?

@branan
Copy link
Contributor

branan commented Mar 31, 2015

Also, shoot. I think we merged #3708 into 4.1 (master). We'll probably want to cherry-pick that back to stable and re-target this PR.

@branan
Copy link
Contributor

branan commented Mar 31, 2015

Assuming we still want this in 4.0, that is (and I think we do)

@branan
Copy link
Contributor

branan commented Mar 31, 2015

With the number of meetings @kylog is in today, I'll take care of all that. Closing this for now, and I'll open a new one targeted at stable with #3708 cherry-picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants