(maint) Mark some tests as pending for Windows 11 #8920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually tested this with local beaker and beaker-puppet checkouts: |
| @@ -23,6 +18,7 @@ | |||
| # but that requires backslashes, that need to be escaped, | |||
| # and the link cannot exist prior. | |||
| on agent, "rm -f #{symlink}" | |||
| # on agent, "cmd /c mklink #{symlink.gsub('/', '\\\\\\\\\\\\')} #{real_source.gsub('/', '\\\\\\\\\\\\')}" | |||
There was a problem hiding this comment.
should this be here?
There was a problem hiding this comment.
Ah nah, that's the change I had to make in order to work with the new template. I'll remove that.
Added `pending_test` for tests that fail on Windows 11. Also dropped 2003 logic in the symlink test since we don't support it anymore.
tvpartytonight
approved these changes
Jun 28, 2022
puppetlabs-jenkins
added a commit
that referenced
this pull request
Jul 6, 2022
Generated by CI * commit 'b68c194bb0cf3e9171fa26b0d5a4e549e2f964f5': (packaging) Updating manpage file for 6.x (maint) Handle Cygwin 3 (maint) Drop special case for symlinks on 2003 Revert "Merge pull request #8920 from joshcooper/win11_6x" Revert "Merge pull request #8922 from joshcooper/win11_6x_user" Conflicts: man/man8/puppet-key.8 man/man8/puppet-man.8 man/man8/puppet-status.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
voxpupuli/beaker#1744, voxpupuli/beaker#1745 must be merged first in order to test Windows 11.
Added
pending_testfor tests that fail on Windows 11. Also dropped 2003 logicin the symlink test since we don't support it anymore.
Filed https://tickets.puppetlabs.com/browse/PUP-11582 so that we investigate why these failure are occurring.