Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Make Docker Postgres configurable #2928

Merged
merged 1 commit into from
May 2, 2019
Merged

(maint) Make Docker Postgres configurable #2928

merged 1 commit into from
May 2, 2019

Conversation

Iristyle
Copy link
Contributor

@Iristyle Iristyle commented May 1, 2019

  • Prior to this commit, the wait script would wait on the host named
    'postgres' with a fixed port of '5432', which is quite inflexible.

    In testing the Pupperware stack, it's necessary to change the host
    to postgres.local to align with other hosts.

    This will allow that configuration change to be made more easily
    at runtime

@Iristyle
(maint) Make Docker Postgres configurable
15c22ce 
 - Prior to this commit, the wait script would wait on the host named
   'postgres' with a fixed port of '5432', which is quite inflexible.

   In testing the Pupperware stack, it's necessary to change the host
   to `postgres.local` to align with other hosts.

   This will allow that configuration change to be made more easily
   at runtime
@Iristyle Iristyle requested a review from a team as a code owner May 1, 2019 23:48
@puppetlabs-jenkins
Copy link
Contributor

Test PASSed

@puppetcla
Copy link

CLA signed by all contributors.

@Iristyle Iristyle mentioned this pull request May 2, 2019
Merged
@Iristyle
Copy link
Contributor Author

Iristyle commented May 2, 2019

Spun up the pupperware cluster with this change and a docker-compose.yml that sets PUPPETDB_POSTGRES_HOSTNAME=postgres.local - pdb queries the right host / logs properly

puppetdb_1  | ......................wtfc.sh: nc -v -w 1 -z 'postgres.local' 5432 finished with expected status 0 after 22 seconds

The container reaches healthy and the it properly builds the connection string to connect to Postgres.

@Iristyle Iristyle merged commit b1ee76e into puppetlabs:master May 2, 2019
@Iristyle Iristyle deleted the docker-wait-on-configurable-postgres-hostname branch May 2, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Iristyle @puppetlabs-jenkins @puppetcla