(maint) Switch PDB container off of Alpine #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwolfe
approved these changes
Aug 13, 2019
- Alpine seems to still be having issues with DNS resolutions inside an LCOW environment. In an effort to reduce these transient problems, switch the base container to a non-Alpine platform. A ticket has been filed with a repro for Alpine DNS issues under LCOW moby/libnetwork#2371 - While this may increase the image size by about 100MB, the goal here is reliability and robustness for the builder container: clojure:lein-alpine was about 142MB clojure:openjdk-8-lein is about 507MB for the target container: openjdk:8-jre-alpine was about 85MB openjdk:8-buster-slim is about 184MB - Ubuntu 18.04 shares a lineage with debian buster, which should be a well supported platform for PDB All OpenJDK container variants are listed at: https://github.com/docker-library/docs/blob/master/openjdk/README.md#supported-tags-and-respective-dockerfile-links
Iristyle
force-pushed
the
change-puppetdb-base-container
branch
from
9c202f1 to
e2e6004
Compare
|
Decided it's not worth investigating that. |
|
CLA signed by all contributors. |
Iristyle
added a commit
to Iristyle/puppetdb
that referenced
this pull request
Aug 15, 2019
- When the base container image was changed from Alpine Linux to Debian Slim Buster in puppetlabs#3040, the /bin/sh implementation changed. 3c876e5 merged this code On Alpine, /bin/sh is the standard bare-bones cross-platform Bourne Shell. On Debian, /bin/sh is a symlink to dash. - Update shellscript syntax to be compatible with Dash.
Iristyle
added a commit
that referenced
this pull request
Aug 15, 2019
- When the base container image was changed from Alpine Linux to Debian Slim Buster in #3040, the /bin/sh implementation changed. 3c876e5 merged this code On Alpine, /bin/sh is the standard bare-bones cross-platform Bourne Shell. On Debian, /bin/sh is a symlink to dash. - Update shellscript syntax to be compatible with Dash.
Iristyle
added a commit
to Iristyle/puppetdb
that referenced
this pull request
Oct 28, 2019
- When the base container image was changed from Alpine Linux to Debian Slim Buster in puppetlabs#3040, the /bin/sh implementation changed. 3c876e5 merged this code On Alpine, /bin/sh is the standard bare-bones cross-platform Bourne Shell. On Debian, /bin/sh is a symlink to dash. - Update shellscript syntax to be compatible with Dash.
binford2k
referenced
this pull request
in voxpupuli/container-puppetdb
Nov 1, 2022
- When the base container image was changed from Alpine Linux to Debian Slim Buster in #3040, the /bin/sh implementation changed. 1777702 merged this code On Alpine, /bin/sh is the standard bare-bones cross-platform Bourne Shell. On Debian, /bin/sh is a symlink to dash. - Update shellscript syntax to be compatible with Dash.
binford2k
referenced
this pull request
in voxpupuli/container-puppetdb
Nov 1, 2022
- When the base container image was changed from Alpine Linux to Debian Slim Buster in #3040, the /bin/sh implementation changed. 1777702 merged this code On Alpine, /bin/sh is the standard bare-bones cross-platform Bourne Shell. On Debian, /bin/sh is a symlink to dash. - Update shellscript syntax to be compatible with Dash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpine seems to still be having issues with DNS resolutions inside
an LCOW environment. In an effort to reduce these transient
problems, switch the base container to a non-Alpine platform.
A ticket has been filed with a repro for Alpine DNS issues under LCOW
LCOW: Intermittent DNS resolution failures with Alpine containers moby/libnetwork#2371
While this may increase the image size by about 100MB, the goal here
is reliability and robustness
for the builder container:
clojure:lein-alpine was about 142MB
clojure:openjdk-8-lein is about 507MB
for the target container:
openjdk:8-jre-alpine was about 85MB
openjdk:8-buster-slim is about 184MB
Ubuntu 18.04 shares a lineage with debian buster, which should
be a well supported platform for PDB
All OpenJDK container variants are listed at:
https://github.com/docker-library/docs/blob/master/openjdk/README.md#supported-tags-and-respective-dockerfile-links