Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-cat-9) Update module to match current syntax standard #1053

Merged
merged 1 commit into from
Aug 24, 2022
Merged

(GH-cat-9) Update module to match current syntax standard #1053

merged 1 commit into from
Aug 24, 2022

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Aug 18, 2022 •
edited
Loading

Module is now in compliance with the following rules:

  • optional_default
  • strict_indent
  • unquoted_string_in_case
  • parameter_documentation
  • relative_classname_inclusion
  • no-top_scope_facts-check
  • no-top_scope_variable-check
  • variable_scope

The below exception has been left in place:

  • disable_anchor_resource

@puppet-community-rangefinder
Copy link

apt::pin is a type

Breaking changes to this file WILL impact these 32 modules (exact match):
Breaking changes to this file MAY impact these 10 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan david22swan force-pushed the GH-cat-9 branch 3 times, most recently from d691133 to 0598065 Compare August 18, 2022 10:07
@david22swan david22swan marked this pull request as ready for review August 18, 2022 10:11
@david22swan david22swan requested a review from a team as a code owner August 18, 2022 10:11
@david22swan david22swan force-pushed the GH-cat-9 branch 3 times, most recently from 6fbb2ef to a2f030f Compare August 18, 2022 12:48
@david22swan
(GH-cat-9) Update module to match current syntax standard
cb6e58c 
Module is now in compliance with the following rules:
- optional_default
- strict_indent
- unquoted_string_in_case
- parameter_documentation
- relative_classname_inclusion
- no-top_scope_facts-check
- no-top_scope_variable-check
- variable_scope

The below exception has been left in place:
- disable_anchor_resource
GSPatton
GSPatton approved these changes Aug 24, 2022
View reviewed changes
Copy link

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me

@chelnak chelnak self-requested a review August 24, 2022 16:11
chelnak
chelnak approved these changes Aug 24, 2022
View reviewed changes
Copy link

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chelnak chelnak merged commit dad7d73 into puppetlabs:main Aug 24, 2022
@jensk
Copy link

jensk commented Feb 18, 2023

This changeset introduces a warning which breaks an important part of the update manifest

Warning: Unknown variable: 'apt::apt_update_last_success'. (file: /usr/local/puppet/vendor/apt/manifests/update.pp, line: 22, column: 12)

@kenyon
Copy link

kenyon commented Feb 18, 2023

@jensk that should have been fixed in #1081.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelnak chelnak chelnak approved these changes

@GSPatton GSPatton GSPatton approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@david22swan @jensk @kenyon @chelnak @GSPatton