Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Debian 9 and Ubuntu pre-18.04 specialcases #1142

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

evgeni
Copy link

@evgeni evgeni commented Oct 28, 2023

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@evgeni evgeni requested review from bastelfreak, smortex and a team as code owners October 28, 2023 18:43
@@ -391,14 +391,10 @@

case $facts['os']['name'] {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, the whole case could be removed and the gnupg ensure could be made unconditional?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, same with the change in key.pp.

Debian 9 support was removed in 12a99c9
Support for 16.04 was removed in 7afbf7e
Support for 14.04 was removed in 62f6ec1
@bastelfreak bastelfreak merged commit 8eb98e5 into puppetlabs:main Nov 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants