(MODULES-9224) Add no progress flag #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
suggested changes
Jun 12, 2019
There was a problem hiding this comment.
Great work, but I disagree that readme doesn't need to change. I think the explanation in the changelog should be just copypastad to https://github.com/puppetlabs/puppetlabs-chocolatey#passing-flags-with-package-settings
Prior to this commit calls to Chocolatey to install or to upgrade packages did not specify the `--no-progress` flag even when it is available. This would sometimes cause the puppet logs to include numerous lines of packages being downloaded which is not particularly helpful. This commit helps to reduce the noise in the logs by making sure that the `--no-progress` flag is specified by default if the version of Chocolatey on the machine supports it. If, however, the resource also specifies the package setting `verbose` as true then the `--no-progress` flag will not be passed as the user is specifically requesting verbose output. This commit includes updates to the provider, common helpers, and spec tests. It does not include any additional user facing documentation as this is an improvement which reduces noise but does not otherwise require configuration.
jpogran
approved these changes
Jun 12, 2019
michaeltlombardi
deleted the
ticket/master/MODULES-9224-no-progress-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit calls to Chocolatey to install or to
upgrade packages did not specify the
--no-progressflageven when it is available. This would sometimes cause the
puppet logs to include numerous lines of packages being
downloaded which is not particularly helpful.
This commit helps to reduce the noise in the logs by making
sure that the
--no-progressflag is specified by defaultif the version of Chocolatey on the machine supports it.
If, however, the resource also specifies the package setting
verboseas true then the--no-progressflag will not bepassed as the user is specifically requesting verbose output.
This commit includes updates to the provider, common helpers,
and spec tests. It does not include any additional user facing
documentation as this is an improvement which reduces noise
but does not otherwise require configuration.