Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-8194) Convert tests to litmus #156

Merged
merged 1 commit into from
Jul 9, 2019
Merged

(FM-8194) Convert tests to litmus #156

merged 1 commit into from
Jul 9, 2019

Conversation

eimlav
Copy link

@eimlav eimlav commented Jun 20, 2019

This commit completely converts acceptance testing to use litmus. As
part of this, I have also carried out an audit of existing testing to
streamline it and remove unnecessary tests.

@eimlav eimlav added the feature label Jun 20, 2019
@eimlav eimlav changed the title (FM-8194) Convert tests to litmus [WIP] (FM-8194) Convert tests to litmus Jun 20, 2019
@eimlav eimlav force-pushed the fm-8194 branch 2 times, most recently from f48445c to f6d1a0e Compare June 20, 2019 16:09
@ThoughtCrhyme
Copy link

This PR removes beaker testing from the spec/acceptance directory. We want to preserve the beaker tests so that we get the benefit of master/agent testing. To get the beaker and litmus tests to exist simultaneously I've added a spec/limus directory to dsc. Take a look here: puppetlabs-toy-chest/puppetlabs-dsc#414

Copy link

@ThoughtCrhyme ThoughtCrhyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@eimlav eimlav force-pushed the fm-8194 branch 17 times, most recently from 3123b8f to bd83f0b Compare July 1, 2019 13:08
@eimlav eimlav force-pushed the fm-8194 branch 2 times, most recently from bd83f0b to 746c944 Compare July 5, 2019 09:47
@eimlav eimlav changed the title [WIP] (FM-8194) Convert tests to litmus (FM-8194) Convert tests to litmus Jul 5, 2019
@eimlav eimlav requested a review from ThoughtCrhyme July 8, 2019 10:38
Copy link

@ThoughtCrhyme ThoughtCrhyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot cleaner, just a few nits.

.fixtures.yml Outdated Show resolved Hide resolved
.sync.yml Outdated Show resolved Hide resolved
appveyor.yml Outdated Show resolved Hide resolved
distelli-manifest.yml Outdated Show resolved Hide resolved
provision.yaml Outdated Show resolved Hide resolved
spec/acceptance/config_values_spec.rb Show resolved Hide resolved
spec/acceptance/config_values_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/features_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/package_spec.rb Outdated Show resolved Hide resolved
spec/support/scripts/backup_config.ps1 Outdated Show resolved Hide resolved
@eimlav eimlav force-pushed the fm-8194 branch 2 times, most recently from a71239d to b1b38c0 Compare July 9, 2019 09:36
This commit completely converts acceptance testing to use litmus. As
part of this, I have also carried out an audit of existing testing to
streamline it and remove unnecessary tests.
@ThoughtCrhyme ThoughtCrhyme merged commit 624ef14 into master Jul 9, 2019
@eimlav eimlav deleted the fm-8194 branch July 10, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants