Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update holdable feature #270

Merged
merged 1 commit into from
May 12, 2022
Merged

update holdable feature #270

merged 1 commit into from
May 12, 2022

Conversation

rico89
Copy link

@rico89 rico89 commented Dec 2, 2021

The package provider did not support holdable anymore since there were various changes in the type. The ensure parameter does not support the :mark value anymore. Instead, if a package should be held, it has to be done with the :mark property. This change updates the provider to support the :mark property and therefore support holdable again.

  • support ensure => mark for puppet 6 with the implementation of the 'deprecated_hold' function
  • add support for property mark
  • add rspec tests

@rico89 rico89 requested a review from a team as a code owner December 2, 2021 15:27
@chelnak chelnak closed this Apr 8, 2022
@chelnak chelnak closed this Apr 8, 2022
@chelnak chelnak reopened this Apr 8, 2022
@chelnak chelnak reopened this Apr 8, 2022
@chelnak
Copy link

chelnak commented Apr 8, 2022

Hey @rico89! Please can you rebase this PR?

@chelnak chelnak merged commit 011a934 into puppetlabs:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants