(GH-283) Fix deprecation error

[chelnak]

Context

Fixes #283

In situations where the resource described in the manifest includes a version in its ensure property and choco v1 or above is installed, puppet runs would fail. This was happening of an issue where the version of chocolatey was not being properly derived by choco_version.

In turn, would cause compiled_choco to return false causing the module to default to using choco update rather than choco upgrade.

What has changed?

This PR fixes that by ensuring that the choco_version method returns the correct puppet version.

We can now observe the correct behaviour, even when the chocolateyversion fact has not been populated.

Debug: Facter: resolving fact with user_query: chocolateyversion
Debug: Facter: Searching fact: chocolateyversion in file: chocolateyversion.rb
Debug: Facter: List of resolvable facts: [#<Facter::SearchedFact:0x000001f3c8dae6a8 @name="chocolateyversion", @fact_class=nil, @user_query="chocolateyversion", @type=:custom, @file=nil>]
Debug: Facter: Searching fact: chocolateyversion in core facts and external facts
Debug: Facter: Loading all internal facts
Debug: Facter: Loading external facts
Debug: Facter: fact "chocolateyversion" has resolved to: 0
Debug: Executing: 'C:\ProgramData\chocolatey\choco.exe upgrade pwsh --version 7.2.2 -y  --ignore-package-exit-codes --no-progress'