Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-774) Puppet 8 support / Drop Puppet 6 #316

Merged
merged 36 commits into from
Apr 19, 2023

Conversation

LukasAud
Copy link

@LukasAud LukasAud commented Apr 3, 2023

This PR aims to update the module with compatibility for the upcoming
Puppet 8 agent release. The most relevant changes introduced in this
updated are:
Updated version requirements in metadata.json
Bumped Rubocop gems
Adjusted Rubocop configuration
Resolved new Rubocop offenses

Note: troubleshooting required some options hashing as a result of this issue arising in Ruby 3+ (rspec/rspec-mocks#1460)

LukasAud added 8 commits April 3, 2023 13:11
This PR aims to update the module with compatibility for the upcoming
Puppet 8 agent release. The most relevant changes introduced in this
updated are:
Updated version requirements in metadata.json
Bumped Rubocop gems
Adjusted Rubocop configuration
Resolved new Rubocop offenses
@LukasAud LukasAud requested a review from a team as a code owner April 3, 2023 14:08
@LukasAud LukasAud force-pushed the CONT-774-Puppet_8_support branch from cc0c1d0 to 14aa2ed Compare April 4, 2023 10:12
@LukasAud LukasAud changed the title (CONT-774) Puppet 8 support (CONT-774) Puppet 8 support / Drop Puppet 6 Apr 17, 2023
@LukasAud LukasAud force-pushed the CONT-774-Puppet_8_support branch from 237b858 to 46c52eb Compare April 19, 2023 09:57
@LukasAud LukasAud force-pushed the CONT-774-Puppet_8_support branch from 46c52eb to 2eb194e Compare April 19, 2023 10:04
Copy link

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jordanbreen28 jordanbreen28 merged commit bc7f5f5 into main Apr 19, 2023
@jordanbreen28 jordanbreen28 deleted the CONT-774-Puppet_8_support branch April 19, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants