forked from chocolatey-archive/puppet-chocolatey
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CONT-774) Puppet 8 support / Drop Puppet 6 #316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to update the module with compatibility for the upcoming Puppet 8 agent release. The most relevant changes introduced in this updated are: Updated version requirements in metadata.json Bumped Rubocop gems Adjusted Rubocop configuration Resolved new Rubocop offenses
This commit introduces reusable workflows.
LukasAud
force-pushed
the
CONT-774-Puppet_8_support
branch
from
April 4, 2023 10:12
cc0c1d0
to
14aa2ed
Compare
LukasAud
changed the title
(CONT-774) Puppet 8 support
(CONT-774) Puppet 8 support / Drop Puppet 6
Apr 17, 2023
LukasAud
force-pushed
the
CONT-774-Puppet_8_support
branch
from
April 19, 2023 09:57
237b858
to
46c52eb
Compare
LukasAud
force-pushed
the
CONT-774-Puppet_8_support
branch
from
April 19, 2023 10:04
46c52eb
to
2eb194e
Compare
jordanbreen28
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update the module with compatibility for the upcoming
Puppet 8 agent release. The most relevant changes introduced in this
updated are:
Updated version requirements in metadata.json
Bumped Rubocop gems
Adjusted Rubocop configuration
Resolved new Rubocop offenses
Note: troubleshooting required some options hashing as a result of this issue arising in Ruby 3+ (rspec/rspec-mocks#1460)