(MODULES-5383) Remove exit codes arg with feature #84
Conversation
| return false if feature_tags.empty? | ||
| feature = feature_tags.first | ||
|
|
||
| return true if feature.attributes['enabled'].downcase == 'true' |
There was a problem hiding this comment.
This should check if it was explicitly enabled - <feature name="usePackageExitCodes" enabled="true" setExplicitly="false" description="[..snip..]" />
Otherwise this is likely to break all folks - the feature is turned on by default.
There was a problem hiding this comment.
I've changed this to check for the feature being enabled explicitly.
|
@ferventcoder I agree. I haven't been using this feature for that reason (originally I thought it might help solve an issue I was having, which lead me to discover that the Despite this, I do think it makes sense to have the |
|
@ferventcoder Have you had a chance to take a look at my last comment and this PR? |
When the "usepackageexitcodes" feature is enabled with the chocolateyfeature resource, this commit ensures that the --ignore-package-exit-codes argument is not passed to the choco binary and that the feature is respected. Previously, the --ignore-package-exit-codes argument would be passed all the time (on versions of Chocolatey where it existed) and this would result in the enabling of the "usepackageexitcodes" feature to be rendered moot.
Chocolatey enables the "usepackageexitcodes" by default, therefore this will break existing behaviour of puppetlabs-chocolatey if it we do not check that the feature was set explicitly. This commit adds new methods to the provider to retrieve chocolatey features from the configuration file. It uses these methods to verify whether or not the `usepackageexitcodes` configuration setting is explicitly set to enabled. If it is disabled or implicitly set, the provider will add the `--ignore-package-exit-codes` parameter when installing packages as is the existing behavior. If it is explicitly set to enabled then the provider will *not* pass that parameter. This is likely to break runs but respects the configuration settings.
|
Hey, @davidtwco! Thank you so much for this PR! I've caught it up to current and added some additional tests, so we're going to merge! I super appreciate your work on this! |
When the "usepackageexitcodes" feature is enabled with the
chocolateyfeature resource, this commit ensures that the
--ignore-package-exit-codes argument is not passed to the choco binary
and that the feature is respected.
Previously, the --ignore-package-exit-codes argument would be passed all
the time (on versions of Chocolatey where it existed) and this would
result in the enabling of the "usepackageexitcodes" feature to be
rendered moot.