(MODULES-7857) Support user creation on galera #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFedotov
force-pushed
the
fix_user_creation_on_galera
branch
from
434b7a9 to
9ede9a8
Compare
|
@MaxFedotov Could you add some test coverage for your new feature and update the docs please? |
|
@david22swan Hi. Can you please clarify, which docs should be updated? This PR doesn't add new functionality, it's just reuses the same logic, which is already implemented for DROP USER . I've looked throught all docs, and wasn't able to find anything related to this. |
MaxFedotov
force-pushed
the
fix_user_creation_on_galera
branch
from
9ede9a8 to
784fc81
Compare
|
@david22swan I've rebased on current master and slightly modified my PR. Also i've updated tests. |
MaxFedotov
force-pushed
the
fix_user_creation_on_galera
branch
from
784fc81 to
5a5789c
Compare
MaxFedotov
force-pushed
the
fix_user_creation_on_galera
branch
from
5a5789c to
8811c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support user creation on galera. Add IF NOT EXISTS to CREATE USER in mysql_user provider
Description of issue in jira - https://tickets.puppetlabs.com/browse/MODULES-7857