(MODULES-2207) Gem restrictions for Older puppet versions #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferventcoder
force-pushed
the
maint/master/modsync-changes
branch
from
9760d65 to
7744bfe
Compare
ferventcoder
changed the title
ferventcoder
force-pushed
the
maint/master/modsync-changes
branch
from
1a499cd to
432a84a
Compare
Further restrict down the restrictions on windows dependencies when using older Puppet versions, such that it works with Puppet 3.0.0 - 3.7.0. It does require a bit more logic in selecting gems but it allows for testing older platforms without any additional known issues for Puppet versions under 3.4.0.
ferventcoder
force-pushed
the
maint/master/modsync-changes
branch
from
432a84a to
6599559
Compare
| @@ -18,6 +18,7 @@ Gemfile: | |||
| version: '~>0.10.5' | |||
| ':system_tests': | |||
| - gem: beaker | |||
| - gem: beaker-rspec | |||
There was a problem hiding this comment.
This should not be here, we should put this in sync.yml when needed.
There was a problem hiding this comment.
I'm 6 to one, half dozen to the other on this. Was more for supporting what @justinstoller might be calling in his scripts. Does it do harm if it is there?
|
@ferventcoder can we clean up the commits of add and remove beaker-rspec |
|
Yes. |
There is an issue with rspec 2.14.0 - it doesn't have `any_instance_recorder_for` which rspec-puppet uses. The fix is simply to move the dependency to `~> 2.14.1` which does have `any_instance_recorder_for`.
ferventcoder
force-pushed
the
maint/master/modsync-changes
branch
from
af5780d to
7074ca7
Compare
|
Removed. |
cyberious
added a commit
that referenced
this pull request
Jul 17, 2015
(MODULES-2207) Gem restrictions for Older puppet versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further restrict down the restrictions on windows dependencies when
using older Puppet versions, such that it works with Puppet 3.0.0 -
3.7.0. It does require a bit more logic in selecting gems but it allows
for testing older platforms without any additional known issues for
Puppet versions under 3.4.0.