Convert variables and if/then logic to Hiera-based yaml files.

data/os/Debian.yaml

@@ -0,0 +1,3 @@
+---
+
+rsync::server::conf_file: '/etc/rsyncd.conf'

data/os/FreeBSD.yaml

@@ -0,0 +1,4 @@
+---
+
+rsync::server::conf_file: '/usr/local/etc/rsync/rsyncd.conf'
+rsync::server::servicename: 'rsyncd'

data/os/RedHat.yaml

@@ -0,0 +1,4 @@
+---
+
+rsync::server::conf_file: '/etc/rsyncd.conf'
+rsync::server::servicename: 'rsyncd'

data/os/RedHat/8.yaml

@@ -0,0 +1,4 @@
+---
+
+# RHEL8 and newer have a separate package for the rsync daemon.
+rsync::server::package_name: rsync-daemon

data/os/RedHat/9.yaml

@@ -0,0 +1,4 @@
+---
+
+# RHEL8 and newer have a separate package for the rsync daemon.
+rsync::server::package_name: rsync-daemon

data/os/Suse.yaml

@@ -0,0 +1,4 @@
+---
+
+rsync::server::conf_file: '/etc/rsyncd.conf'
+rsync::server::servicename: 'rsyncd'

manifests/server.pp

@@ -7,39 +7,22 @@
 #   class rsync
 #
 class rsync::server(
-  $use_xinetd = true,
-  $address    = '0.0.0.0',
-  $motd_file  = 'UNSET',
+  Boolean                                    $use_xinetd = true,
+  $address                                               = '0.0.0.0',
+  $motd_file                                             = 'UNSET',
   Variant[Enum['UNSET'], Stdlib::Absolutepath] $pid_file = '/var/run/rsyncd.pid',
-  $use_chroot = 'yes',
-  $uid        = 'nobody',
-  $gid        = 'nobody',
-  $modules    = {},
+  $use_chroot                                            = 'yes',
+  $uid                                                   = 'nobody',
+  $gid                                                   = 'nobody',
+  $modules                                               = {},
+  Optional[String[1]]                               $package_name = undef,
+  String[1]                              $conf_file      = '/etc/rsync.conf',
+  String[1]                               $servicename   = 'rsync',
+  Stdlib::Ensure::Service                $service_ensure = 'running',
+  Boolean                                $service_enable = true,
+  Boolean                                $manage_package = $rsync::manage_package,
 ) inherits rsync {
 
-  case $facts['os']['family'] {
-    'Debian': {
-      $conf_file = '/etc/rsyncd.conf'
-      $servicename = 'rsync'
-    }
-    'Suse': {
-      $conf_file = '/etc/rsyncd.conf'
-      $servicename = 'rsyncd'
-    }
-    'RedHat': {
-      $conf_file = '/etc/rsyncd.conf'
-      $servicename = 'rsyncd'
-    }
-    'FreeBSD': {
-      $conf_file = '/usr/local/etc/rsync/rsyncd.conf'
-      $servicename = 'rsyncd'
-    }
-    default: {
-      $conf_file = '/etc/rsync.conf'
-      $servicename = 'rsync'
-    }
-  }
-
   if $use_xinetd {
     include xinetd
     xinetd::service { 'rsync':
@@ -50,18 +33,23 @@
       require     => Package['rsync'],
     }
   } else {
-    if ($facts['os']['family'] == 'RedHat') and
-        (Integer($facts['os']['release']['major']) >= 8) and
-        ($rsync::manage_package) {
-      package { 'rsync-daemon':
-        ensure => $rsync::package_ensure,
-        notify => Service[$servicename],
+
+    # Manage the installation of the rsyncd package?
+    if $manage_package {
+
+      # RHEL8 and newer (and their variants) have a separate package for rsyncd daemon.  If the $package_name
+      # variable is defined (the variable is defined in the hiera hierarchy), then install the package.
+      if $package_name {
+        package {$package_name:
+          ensure => $rsync::package_ensure,
+          notify => Service[$servicename],
+        }
       }
     }
 
     service { $servicename:
-      ensure     => running,
-      enable     => true,
+      ensure     => $service_ensure,
+      enable     => $service_enable,
       hasstatus  => true,
       hasrestart => true,
       subscribe  => Concat[$conf_file],