Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CONT-1123) - Add Puppet 8/Drop Puppet 6 #213

Merged
merged 2 commits into from
Jun 23, 2023
Merged

(CONT-1123) - Add Puppet 8/Drop Puppet 6 #213

merged 2 commits into from
Jun 23, 2023

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Jun 20, 2023 •
edited
Loading

Summary

Updating puppet agent and puppet version dependency.

Additional Context

Add any additional context about the problem here.

  • Updating dependent module version to keep satellite_pe_tools updated

Related Issues (if any)

N/A

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Ramesh7 Ramesh7 requested a review from a team as a code owner June 20, 2023 14:51
@Ramesh7 Ramesh7 changed the title (CONT-1123) - Update agent and puppet version (CONT-1123) - Add Puppet 8/Drop Puppet 6 Jun 20, 2023
@Ramesh7 Ramesh7 added the WIP label Jun 20, 2023
@Ramesh7 Ramesh7 force-pushed the CONT-1123-update_agent_version branch 8 times, most recently from 5c1818a to ea652b5 Compare June 21, 2023 08:52
@Ramesh7 Ramesh7 added maintenance and removed WIP labels Jun 21, 2023
@jordanbreen28
Copy link
Contributor

jordanbreen28 commented Jun 21, 2023 •
edited
Loading

@Ramesh7 PR needs backwards-incompatible label, we're removing support for Puppet 6 here.

jordanbreen28
jordanbreen28 reviewed Jun 21, 2023
View reviewed changes
.puppet-lint.rc Outdated Show resolved Hide resolved
.rubocop_todo.yml Outdated Show resolved Hide resolved
spec/classes/init_spec.rb Outdated Show resolved Hide resolved
@Ramesh7 Ramesh7 force-pushed the CONT-1123-update_agent_version branch from ea652b5 to e38a79e Compare June 21, 2023 10:14
@Ramesh7 Ramesh7 force-pushed the CONT-1123-update_agent_version branch from e38a79e to 27d5b91 Compare June 21, 2023 11:55
@Ramesh7 Ramesh7 force-pushed the CONT-1123-update_agent_version branch 5 times, most recently from e7108f5 to 029329b Compare June 21, 2023 16:32
@Ramesh7 Ramesh7 force-pushed the CONT-1123-update_agent_version branch from 029329b to e36f982 Compare June 22, 2023 05:09
@Ramesh7 Ramesh7 force-pushed the CONT-1123-update_agent_version branch from e36f982 to 0159b56 Compare June 22, 2023 12:32
@chelnak chelnak merged commit 408484c into main Jun 23, 2023
@chelnak chelnak deleted the CONT-1123-update_agent_version branch June 23, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanbreen28 jordanbreen28 jordanbreen28 left review comments

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ramesh7 @jordanbreen28 @chelnak