New argument to set exportability of the certificate #46
Conversation
…updated with this info. Spec tests added. Tests use a different certificate thumbprint.The test certificate is spec/testCert.pfx fixing style errors,rubocop errors Committer: ricardogaspar2 <[email protected]>
ricardogaspar2
force-pushed
the
exportable_flag
branch
from
a2536d5 to
8d15be5
Compare
manifests/init.pp
Outdated
| ensure => directory | ||
| } | ||
| ) | ||
|
|
There was a problem hiding this comment.
I think the closing parenthesis should follow the brace on the same line.
manifests/init.pp
Outdated
| $root_store = 'LocalMachine', | ||
| $store_dir = 'My', | ||
| $scripts_dir = 'C:\temp', | ||
| $is_exportable = true) { |
There was a problem hiding this comment.
I'd prefer this to be just exportable instead.
Is 'My' a good default for store_dir?
This should probably be converted to use Puppet 4 datatypes, so that you can get rid of the validate calls below
There was a problem hiding this comment.
Yes, 'My' is a default dir. I just have extended the code, as you can see, I maintained the default options/parameters.
manifests/init.pp
Outdated
| $key_storage_flags = 'Exportable,PersistKeySet' | ||
| }else{ | ||
| $key_storage_flags = 'PersistKeySet' | ||
| } | ||
|
|
There was a problem hiding this comment.
the parentheses around $is_exportable are superfluous, and you should have whitespace around else, I think
|
@oranenj please review the code after the changes you requested. |
|
This seems fine to me on a general level. Someone else will have to merge though, as I can't say I'm very familiar with the domain specifically. |
|
Do you know who can merge and when can it be merged? |
|
Would have preferred two separate PRs, but merging anyway |
Adding a new argument to specify the location of the scripts. README updated with this info. Spec tests added. Tests use a different certificate thumbprint.The test certificate is spec/testCert.pfx
This is a combined pull it contains two features:
#45 (new argument to specify a directory to store the scripts) and #46 itself (flag to set the exportability of the certificate key).