Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1521) - Adding RHEL-9-ARM in CI pipeline #1404

Closed
wants to merge 1 commit into from
Closed

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Oct 23, 2023

Summary

Adding RHEL-9-ARM in CI pipeline

Additional Context

N/A

Related Issues (if any)

N/A

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Ramesh7 Ramesh7 added the WIP Work In Progress label Oct 23, 2023
@@ -16,7 +16,8 @@
"operatingsystemrelease": [
"7",
"8",
"9"
"9",
"9-arm"
Copy link
Collaborator

@ekohl ekohl Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this valid? I always thought operatingsystemrelease had to match the operatingsystemrelease fact that Facter returned.

Edit: though it probably closer matches operatingsystemmajrelease

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry @ekohl, was not able to get much from your comment but I always went with https://github.com/puppetlabs/puppet_litmus/blob/main/exe/matrix_from_metadata_v2#L153 and based on that its expecting operatingsystemrelease.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the spec is more important than what Litmus does. https://www.puppet.com/docs/puppet/7/modules_metadata.html#metadata-operating-system states:

The operatingsystemrelease accepts an array of strings. The Forge displays these versions on module pages, and you can format them in whatever way makes sense for the operating system in question.

So that's not very specific, but it is important to note that the forge will list them. As a user I could think that only RHEL 9 supports ARM, but not RHEL 8 etc. That can be considered misleading.

I always interpreted it that the values it for operatingsystemrelease in metadata.json should match what Facter returned for operatingsystemrelease or operatingsystemmajrelease (or nowadays their modern equivalents).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it now, thanks for explanation. I will check with Agent team about factor values for operatingsystemrelease or operatingsystemmajrelease and will update here.
Thanks @ekohl again!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @jordanbreen28 already handled this into litmus and we don't need this PR anymore.
Hence closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants