(CONT-802) - Revert RSpec/NoExpectationExample #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the work to add support for puppet 8, a rubocop violation
"RSpec/NoExpectationExample" was fixed.
This included adding an expect {} block around puppet applys, which
initially seemed to work as expected.
However it was discovered that this hid error outputs of failed runs,
meaning debugging was impossible.
This commit reverts these changes and adds the cop back to the "todo".
david22swan
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the work to add support for puppet 8, a rubocop violation "RSpec/NoExpectationExample" was fixed.
This included adding an expect {} block around puppet applys, which initially seemed to work as expected.
However it was discovered that this hid error outputs of failed runs, meaning debugging was impossible.
This PR reverts these changes (f375607) and adds the cop back to the "todo".