Update var types #536
Merged
Update var types #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
reviewed
Jul 11, 2023
|
@jordanbreen28 Hello this MR has been idle for some time now could you take a look at or tell me if i need to update anything? |
|
hey @Joris29 apologies for the delay... |
jordanbreen28
approved these changes
Jul 31, 2023
|
thanks for your work on this one @Joris29! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR mainly focuses on providing a better var type to match the description of the parameters
Additional Context
I was getting an error on my puppet runs:
Error while evaluating a Resource Statement:
Tomcat::Config::Server::Connector[tomcat-app-http]: parameter 'port' expects a value of type Undef or String, got Integer
…in …/labo/modules/profile/manifests/tomcat.pp, line: 117.
Checklist
Verified by pinning my branch and running puppet